fix(core): language add ability to define the default language #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelord
approved these changes
Nov 12, 2024
| @@ -29,9 +29,14 @@ const TIMEOUT_DURATION = 5000; | |||
| /** | |||
| * Make sure you only call this method in the root module of your application, most of the time called AppModule. | |||
| */ | |||
| export function provideTranslation(loader?: Provider): EnvironmentProviders { | |||
| export function provideTranslation( | |||
| defaultLanguage?: string | undefined, | |||
There was a problem hiding this comment.
au lieu de string, on ne serait pas mieux de basé sur une enum?
There was a problem hiding this comment.
J'avais mit un Type au début mais après coup vu que cette partie va être utilisé dans d'autre application et librairie, on ne peut connaitre d'avance l'ensemble des langues... Alors je crois que le string est le mieux placés.
fix(core): language use the browser language only if the default is not set
alecarn
force-pushed
the
fix/language
branch
from
7a02b39 to
aaf16c9
Compare
|
🎉 This PR is included in version 18.0.0-next.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(core): language use the browser language only if the default is not set
The browser language was causing a double loading of the translation files. If we had an French Browser but loading the english version it was loading the French translation then the English. The behavior proposed is: If we provide a DEFAULT lang we use this default otherwise we use the browser language.
If we add the query params
lang=enin the browser url, we got duplicated translation files and multiple localization